Kaynağa Gözat

Avoid passing port argument twice in handler init

jherve 1 yıl önce
ebeveyn
işleme
ffea339ba4
3 değiştirilmiş dosya ile 6 ekleme ve 6 silme
  1. 2 2
      make_prod.patch
  2. 2 2
      src/Background.purs
  3. 2 2
      src/NativeMessage.purs

+ 2 - 2
make_prod.patch

@@ -21,6 +21,6 @@ index b73fd21..86d7396 100644
    log "[bg] starting up"
 -  port <- connectToNativeApplication "job_search_background"
 +  port <- connectToNativeApplication "job_search_background.prod"
-   -- TODO: This is redundant to send "port" to both addListener and the handler
-   onNativeMessageAddListener port $ nativeMessageHandler port
+
+   onNativeMessageAddListener port nativeMessageHandler
    onNativeDisconnectAddListener port \p -> log $ "disconnected from native port " <> p.name <> " (" <> p.error <> ")"

+ 2 - 2
src/Background.purs

@@ -29,8 +29,8 @@ main :: Effect Unit
 main = do
   log "[bg] starting up"
   port <- connectToNativeApplication "job_search_background"
-  -- TODO: This is redundant to send "port" to both addListener and the handler
-  onNativeMessageAddListener port $ nativeMessageHandler port
+
+  onNativeMessageAddListener port nativeMessageHandler
   onNativeDisconnectAddListener port \p -> log $ "disconnected from native port " <> p.name <> " (" <> p.error <> ")"
 
   sendConfigurationToNative port

+ 2 - 2
src/NativeMessage.purs

@@ -86,13 +86,13 @@ decodeNativeMessage m =
     Left err -> Left $ printJsonDecodeError err
     Right m' -> Right m'
 
-onNativeMessageAddListener ∷ Port → (NativeMessage → Effect Unit) → Effect Unit
+onNativeMessageAddListener ∷ Port → (Port -> NativeMessage → Effect Unit) → Effect Unit
 onNativeMessageAddListener port f = onMessageAddListener port $ runtimeMessageHandler
   where
     runtimeMessageHandler = mkListener \m -> do
       case decodeNativeMessage m of
         Left err -> log err
-        Right m' -> f m'
+        Right m' -> f port m'
 
 onNativeDisconnectAddListener :: Port -> (Port -> Effect Unit) -> Effect Unit
 onNativeDisconnectAddListener port f = onDisconnectAddListener port $ mkListener f